selma-belhadj / Portfolio

Portfolio Web App shows a sneak peek of what I have done in the programming field and what I can offer to someone who wants to hire me. It is built by HTML, CSS & Vanilla JavaScript.
12 stars 0 forks source link

Morning Session Peer-to-Peer Programing #10

Open Tobinchilongo opened 2 years ago

Tobinchilongo commented 2 years ago

CHANGES REQUIRED

Great job to get this far,

Tobinchilongo commented 2 years ago

Hi @selma-belhadj ,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit: Congratulations! 🎉

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear

VSeray commented 2 years ago

Hello 😄, well done finishing your project 🎉. To make your project more professional I recommend you using the referred links from the final code rather than using the links from your commits. But overall Great Job 👏 👏

joskalenda commented 2 years ago

Nice...! your website is working perfectly, however, following the HTML nest practice we studied earlier, I think it could be more professional writing your code using appropriate element tags instead of div in the main section... it should be nice if inside the main section you use section, article, aside .... Screenshot from 2021-12-10 09-16-25