search

selmeci / dgraph-tonic

Async/Sync gRPC client for Dgraph DB
MIT License
83 stars 8 forks source link

Update dependencies - specifically, tokio, prost, and tonic #32

Closed colin-grapl closed 3 years ago

colin-grapl commented 3 years ago

I've updated three dependencies as part of this PR - tokio, prost, and tonic.

tokio has recently reached 1.0, and since it's a pretty core library, and differing versions can be problematic across crates, I think updating it to 1.0 ASAP makes the most sense - especially since they have some strong semver guarantees post 1.0.

tonic being updated pulls in the 1.0 of tokio, and also the updated prost 0.7.

I've run all of the integration tests locally and everything passes.

selmeci commented 3 years ago

Hi @colin-grapl, thank you for PR. We should probably bump up new version 0.9 because if someone is using libraries which have dependencies for old tokio version, it could break it code.

colin-grapl commented 3 years ago

Sure thing, I've updated the PR.

selmeci commented 3 years ago

I've just check travis for jobs results and there are some improvements for sync client required:

https://travis-ci.org/github/selmeci/dgraph-tonic/jobs/755072451

We should remove unnecessary mutex and simplify all code for synchronous features.

Can you handle it, please?

Thanks.

colin-grapl commented 3 years ago

Done