search

selmf / unarr

A decompression library for rar, tar, zip and 7z archives
GNU Lesser General Public License v3.0
70 stars 13 forks source link

1.0.1: version problems. #1

Closed leamas closed 1 year ago

leamas commented 5 years ago

While version 1.0.1 is, well, 1.0.1 the CMakelists.txt file contains the definition 

project(unarr VERSION 1.0.0 LANGUAGES C)

As a consequence, the pkgconfig file uses a 1.0.0 version and the library becomes libunarr.so.1.0.0.

Since the release is tagged, one idea could be to release a 1.0.2 fixing this?

selmf commented 5 years ago

1.0.1 was just a minor bugfix for the pkgconfig file so I was reluctant to increase the soversion (as there were no changes to the actual library). In hindsight this was probably a bad idea and I should have kept the versions in sync no matter how trivial the changes.

If you need the versions to match, you can patch 1.0.1 into CMakelists.txt for now. I will fix the mismatch in the next version (either 1.0.2 or 1.1.0), so there won't be any conflict.

leamas commented 5 years ago

OK, thanks, will patch.

That said, this does not change the soversion which still is 1 (i. e., soname = libunarr.so.1).

sebastic commented 5 years ago

1.0.1 was just a minor bugfix for the pkgconfig file so I was reluctant to increase the soversion (as there were no changes to the actual library).

I guess you mean "library version" instead of "soversion", because the SOVERSION is set to ${PROJECT_VERSION_MAJOR} and hence remains at 1, only the VERSION changes to 1.0.1 (because it uses ${PROJECT_VERSION}).

selmf commented 5 years ago

Yes, the soversion should only change if there is api/abi breakage. Sorry for the confusion.

selmf commented 1 year ago

Fixed in https://github.com/selmf/unarr/commit/ca745b72684e156c1e1b0445f36675527264746e