selmf / unarr

A decompression library for rar, tar, zip and 7z archives
GNU Lesser General Public License v3.0
73 stars 13 forks source link

Missing `raw` parameter in `x_get_name` calls #14

Closed r0ptr closed 3 years ago

r0ptr commented 3 years ago

I'm getting a compile error on master, where it looks like the recently introduced raw parameter is not passed in the following four calls:

[build] ...\unarr\_7z\_7z.c(78,9): error C2198: '_7z_get_name': too few arguments for call [...\unarr\unarr.vcxproj]
[build]   conv.c
[build]   crc32.c
[build]   stream.c
[build]   unarr.c
[build]   filter-rar.c
[build]   huffman-rar.c
[build]   parse-rar.c
[build]   rar.c
[build] ...\unarr\rar\rar.c(65,21): error C2198: 'rar_get_name': too few arguments for call [...\unarr\unarr.vcxproj]
[build]   uncompress-rar.c
[build]   parse-tar.c
[build]   tar.c
[build] ...\unarr\tar\tar.c(43,9): error C2198: 'tar_get_name': too few arguments for call [...\ext\unarr\unarr.vcxproj]
[build]   parse-zip.c
[build]   uncompress-zip.c
[build]   zip.c
[build] ...\unarr\zip\zip.c(109,9): error C2198: 'zip_get_name': too few arguments for call [...\ext\unarr\unarr.vcxproj]
selmf commented 3 years ago

Hmmm it looks like I missed those when introducing the raw parameter. When building with CMake, these are only triggered when doing a debug build. Shouldn't be hard to fix. If you're not building with CMake you can define NDEBUG as a workaround to get rid of these errors as a workaround.