search

selvamk-js / sharingan-rn-modal-dropdown

A simple and customizable react-native dropdown created using react-native-modal and react-native-paper.
MIT License
85 stars 28 forks source link

my array is more than 500 items #11

Open edx-mohamed-khamis opened 3 years ago

edx-mohamed-khamis commented 3 years ago

Everything works fine in the plugin and i really liked it but when i try it with an array of more than 500 items. i got this message in the terminal VirtualizedList: You have a large list that is slow to update - make sure your renderItem function renders components that follow React performance best practices like PureComponent, shouldComponentUpdate, etc. {"contentLength": 24461.333984375, "dt": 656, "prevDt": 4774}

I don't know if you are aware of this or not anyway i couldn't use it because it's very slow while scrolling + choosing a value but i really liked this plugin.

selvamk-js commented 3 years ago

Hello, @khamisEDX Thanks for the comments 😊 and Yes I do know about the performance issue since I have used it in my project. I am already working on it I will release a new build with improved performance.

SaadAhmadSaddiqui commented 3 years ago

First of all, I want to commend you for this package. It's awesome! I'm surprised not more people have looked into this library. Although, I'm also facing the performance issue and would really like to know if there's any update on that end. Thank you!

selvamk-js commented 3 years ago

@SaadAhmadSaddiqui I am working on this issue since I am busy with other projects I couldn't spend full time fixing it. But, soon will release a new version with improved performance.