search

selwin / python-user-agents

A Python library that provides an easy way to identify devices like mobile phones, tablets and their capabilities by parsing (browser) user agent strings.
MIT License
1.43k stars 196 forks source link

Missing mobile device families #80

Closed emmettbutler closed 7 years ago

emmettbutler commented 7 years ago

This pull request adds to MOBILE_DEVICE_FAMILIES a large number of device families that the parser incorrectly identifies as is_mobile() == False. These device families are all mobile phones.

These device family names were found by running the parser against a Parse.ly internal dataset of user agents the parser had incorrectly identified as tablets, found by @UdayVarkhedkar.

Fixes #73

selwin commented 7 years ago

Thanks for the PR. This library doesn't aim to hardcode every single device families available because that's not a scalable approach but rather look for heuristics.

May I know which movile devices that are currently not properly detected?

emmettbutler commented 7 years ago

@selwin Thanks for being in touch. This PR was just meant to start a discussion, since there are a fair number of mobile devices being incorrectly identified as tablets. The list given here is comprehensive as far as we're concerned at Parse.ly. If you'd like to work together on a way to support these devices heuristically rather than explicitly, I'd be happy to help out.