search

selwin / python-user-agents

A Python library that provides an easy way to identify devices like mobile phones, tablets and their capabilities by parsing (browser) user agent strings.
MIT License
1.43k stars 196 forks source link

Fixed parser to be compatible with new ua-parser #90

Closed IMDagger closed 5 years ago

IMDagger commented 5 years ago

"RT" and "ME" are stored in version now

IMDagger commented 5 years ago

didn't touch travis configuration, but I guess 3.3 (because pip doesn't work) should be removed from the list to pass checks

stefanfoulis commented 5 years ago

I can confirm this fix works as expected for detecting Windows 8 touch devices.

selwin commented 5 years ago

Sorry for the delayed response.

I have just updated travis.yml to support Python 2.7 and Python >= 3.4. Could you please merge the changes to this branch to see if the tests pass?

If we can get this in, I'll cut a release soon.

IMDagger commented 5 years ago

@selwin TravisCI said "3.7 is not installed; attempting download" this time and building was failed for 3.7 case (as for 3.3 previous time)

selwin commented 5 years ago

We should omit Python 3.7 then, let’s just test up to Python 3.6.

IMDagger commented 5 years ago

@selwin I suppose we can try this official workaround for 3.7

selwin commented 5 years ago

Sure, let me know if it works :)

Best, Selwin On 31 Mar 2019 03.48 +0700, Alex Moiseenko notifications@github.com, wrote:

@selwin I suppose we can try this official workaround for 3.7 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

IMDagger commented 5 years ago

Sure, let me know if it works :) Best, Selwin … On 31 Mar 2019 03.48 +0700, Alex Moiseenko @.***>, wrote: @selwin I suppose we can try this official workaround for 3.7 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

I just added "dist: xenial" and 3.7 works now

selwin commented 5 years ago

Thanks!