search

sem-in-r / seminr

Natural feeling domain-specific language for building structural equation models in R for estimation by covariance-based methods (like LISREL/Lavaan) or partial least squares (like SmartPLS)
58 stars 19 forks source link

missing # character in csem2seminr.Rd example #342

Open yrosseel opened 8 months ago

yrosseel commented 8 months ago

In man/csem2seminr.Rd line 20, there is missing comment character ('#') just before 'Composite model'.

The old parser in lavaan simply ignores this line (with a warning), but the new parser in the next update of lavaan is not so forgiving. Could you please fix this and submit to CRAN?

soumyaray commented 8 months ago

Thanks for the catch @yrosseel ! I'll get on it. Can I ask if it would be ok for us to wait a bit to push the fix out as part of a larger update? Does this affect your upcoming efforts or create annoying check warnings for you? I'm asking as CRAN does not seem to like too frequent updates (and I had some other things in mind to fix).

yrosseel commented 8 months ago

No problem. We discovered similar syntax issues in several packages (thanks to the new parser), and they all need time to adapt. In the next update of lavaan (0.6-17, hopefully ready in a few weeks), the old parser will still be the default. But in 0.6-18 (to be released somewhere early next year, I hope), I would prefer to use the "new" parser per default.

soumyaray commented 8 months ago

excellent job on lavaan! we'll catch up.

yrosseel commented 2 months ago

I would like to release of lavaan 0.6-18 (with the new parser) soon. Any ideas when the current version of seminr goes to CRAN?

soumyaray commented 1 month ago

We will get a patch out in coming days – please proceed with lavaan's release as planned! I'll close the issue once our patch is accepted.

yrosseel commented 4 weeks ago

I see the issue is still not fixed on github. I really prefer that this is fixed on CRAN before I upload lavaan. Any idea about the timeline?

soumyaray commented 3 weeks ago

Dear @yrosseel – I'll talk to the maintainer @NicholasDanks today and get it out asap.