semagrow / kobe

Framework for benchmarking SPARQL query federators
https://semagrow.github.io/kobe/
Apache License 2.0
10 stars 1 forks source link

Fixes in operator, fixes in examples, additional examples. and cleanup #9

Closed antru6 closed 4 years ago

antru6 commented 4 years ago

Fixes in operator:

Clean-up of examples:

Fixes in example containers:

Additional examples:

stasinos commented 4 years ago

Please explain how the delay of "10" was calculated, and how to derive this number for future Docker images.

kostbabis commented 4 years ago

Please explain how the delay of "10" was calculated, and how to derive this number for future Docker images.

There is an issue in istio where the sidecar proxy takes too long time to go up since its launched as a main container alongside the others in the pod. Every connection that happens after the istio init container and before the proxy main container is up will fail, thus we need to wait before downloading dumps for example.

There is already a loop at the very beggining that checks connection by repeating curl localhost:15000 every 3 sec

But in our tests seemed to not always be enough. In minikube it was but in the cluster it wasnt. The extra 10 seconds are probably more than enough to make sure that istio is up if there is also that loop present in the beggining of the main container.