search

semanser / vim-outdated-plugins

🔄 Async Vim/Neovim plugin for showing the number of your outdated plugins
51 stars 4 forks source link

Use origin/branch when checking for new commits + python rewrite #16

Open thisisrandy opened 5 years ago

thisisrandy commented 5 years ago

This fixes /issues/14 for me (I have coc.nvim checked out from the release branch).

Additionally, there was some other race-condition-like behavior going on where the on_stdout callback was apparently entered variably fewer times than expected (see 72c9dcf for details). I was unable to resolve it in vimscript, but a python rewrite did the trick.

thisisrandy commented 5 years ago

Oh, I also added a new option g:outdated_plugins_trigger_mode to trigger :PlugUpdate as needed

semanser commented 4 years ago

hi @thisisrandy! Thanks for your work and sorry for my late reply.

I've tried it and it works much better than vimscript version. Good job!

What is the minimal version of python required? I want to update the README file.

semanser commented 4 years ago

It seems like I'm not able to add commits to this PR (I can't push to master branch on your forked repo).

thisisrandy commented 4 years ago

Thanks for your reply, @semanser. I've added you as a collaborator on my fork, so you should have push access now. I developed the python bit using 3.6.8, so I know that's safe. Probably should have added the future imports to make it backward compatible, though. I'll take care of that in a bit, or if you beat me to it, you're welcome to do the same.

thisisrandy commented 4 years ago

Actually, I take that back. The subprocess API changed in python 3, and it seems the run method, which I used, was introduced in 3.5. So 3.5 is the minimum requirement.