search

semantic-kraus / dw-data

converts XML/TEI data into CIDOCish RDF
https://semantic-kraus.github.io/dw-data/
MIT License
0 stars 1 forks source link

dw persons: appellation built wrong #3

Closed BOberreither closed 1 year ago

BOberreither commented 1 year ago

The E33_E41_Linguistic_Appellation ending in "/0" needs fixing; example: 

<https://sk.acdh.oeaw.ac.at/DWpers2333/appellation/0> a ns1:E33_E41_Linguistic_Appellation ;
    rdfs:label "Bedenik, Franz Josef"@und ;
    ns1:P2_has_type <https://sk.acdh.oeaw.ac.at/types/person/persname> .

<https://sk.acdh.oeaw.ac.at/DWpers2333/appellation/1> a ns1:E33_E41_Linguistic_Appellation ;
    rdfs:label "Bedenik, Franz"@und ;
    ns1:P2_has_type <https://sk.acdh.oeaw.ac.at/types/person/persname/sk> ;
    rdf:value "Bedenik, Franz" .

<https://sk.acdh.oeaw.ac.at/DWpers2333/appellation/2> a ns1:E33_E41_Linguistic_Appellation ;
    rdfs:label "Pertz, Josef"@und ;
    ns1:P2_has_type <https://sk.acdh.oeaw.ac.at/types/person/persname/sk> ;
    rdf:value "Pertz, Josef" .

xml source:

<persName>
  <forename>Franz</forename>
  <forename type="taken" subtype="later">Josef</forename>
  <surname>Bedenik</surname>
  <surname type="taken" subtype="later">Pertz</surname>
</persName>
<persName type="sk" subtype="pref">Bedenik, Franz</persName>
<persName type="sk" subtype="taken">Pertz, Josef</persName>
  1. The "appellation/0" seems to take both first names and only one surname from the first persName; the appellations in DW should only be built from persName @type="sk".
  2. Also, the E55_Type of the appellation should not be from persName/@type but from persName[@type="sk"]/@subtype
BOberreither commented 1 year ago

@linX First part of the issue resolved, thanks - now only the second part is left. Looks like: 

<https://sk.acdh.oeaw.ac.at/DWpers2333/appellation/0> a cidoc:E33_E41_Linguistic_Appellation ;
        rdfs:label "Bedenik, Franz"@und ;
        cidoc:P2_has_type <https://sk.acdh.oeaw.ac.at/types/person/persname/sk> ;
        rdf:value "Bedenik, Franz" .

Should look like:

<https://sk.acdh.oeaw.ac.at/DWpers2333/appellation/0> a cidoc:E33_E41_Linguistic_Appellation ;
        rdfs:label "Bedenik, Franz"@und ;
        cidoc:P2_has_type <https://sk.acdh.oeaw.ac.at/types/person/persname/pref> ;
        rdf:value "Bedenik, Franz" .

Line 3: last part of URI is to be taken from @subtype, not @type of persName[@type="sk"]