search

semantic-math / math-rules

Manipulate math-ast ASTs based on algebraic rules
MIT License
4 stars 1 forks source link

Fractions #50

Open aliang8 opened 7 years ago

aliang8 commented 7 years ago

Fixed COMMON_DENOMINATORS to work with non integer denominators.

kevinbarabash commented 7 years ago

This looks good except for the failing test. Any idea what's going on there? It looks like the rule returns an empty string.

aliang8 commented 7 years ago

This PR is not ready to merge. I am still working on taking care of more edge cases.

kevinbarabash commented 7 years ago

@aliang8 is this ready for review now?