search

semantic-release / .github

Common configuration for the semantic-release organization
5 stars 6 forks source link

chore: ignore package versions without CJS support #13

Closed fgreinacher closed 2 years ago

fgreinacher commented 2 years ago

Related to https://github.com/semantic-release/semantic-release/issues/2133

fgreinacher commented 1 year ago

@travi WDYT we revert this now that the main package is migrated?

travi commented 1 year ago

i've been thinking about this too. the downside would be that we dont yet have all the impacted repos updated quite yet and it isnt clear yet how far we are from getting there. it has been nice for this to be in place to reduce the distracting PRs, but i dont think we'd want to move this to the individual repos temporarily either.

i think i'm maybe thinking that we remove this once we get at least a couple of the official plugins fully converted to ESM. once we are there, i'd hope the repos where this would cause a negative impact would be faster to get resolved too.

please do keep reminding of this one, though. i do want to get it handled once the timing is a little better

fgreinacher commented 1 year ago

Sure, this makes sense! I’ll probably just override the relevant options locally to receive those updates!