search

semantic-release / cli

:cl::round_pushpin: Setup automated semver compliant package publishing
MIT License
367 stars 45 forks source link

fix(github): fixes bug with github token #355

Closed cujarrett closed 3 years ago

cujarrett commented 3 years ago

What

Sample local run

❯ npm ls -g --depth=0
/usr/local/lib
├── semantic-release-cli@0.0.0-development -> /Users/REDACTED/Developer/cli
└── semantic-release@17.3.1

~/Developer/REDACTED add-semantic-release
❯ semantic-release-cli setup --npm-token=REDACTED
? What is your npm registry? https://registry.npmjs.org/
? Provide a GitHub Personal Access Token (create a token at https://github.com/settings/tokens/new?scopes=repo) REDACTED
? What CI are you using? Circle CI
? What is your CircleCI API token? REDACTED
? Do you want a `config.yml` file with semantic-release setup? No

~/Developer/glimpse add-semantic-release* 33s

@gr2m - Please let me know if this looks ok to fix logging the GitHub token to the package.json via the removal of pkg in PR 352

gr2m commented 3 years ago

I don't quite understand how this change would affect anything? You add the pkg as first argument to the github function, but it's not used at all? What am I missing?

cujarrett commented 3 years ago

@gr2m - I beleive it's being mistakenly written from here: https://github.com/semantic-release/cli/blob/master/src/index.js#L115. If you think this is not needed feel free to close.

gr2m commented 3 years ago

I think this change makes no difference, so I'm going to close it. Thank you though!