semantic-release / condition-travis

:no_entry_sign: semantic-release plugin to check Travis CI environment before publishing.
MIT License
9 stars 11 forks source link

Replace coveralls with codecov #74

Closed pvdlg closed 7 years ago

pvdlg commented 7 years ago

Fix #70

@gr2m Can you make the codecov config (add repo to codecov, get the token and add it to Travis) or make me admin so I can do it? Thanks !

We should do that before merging this PR, so we can test everything works by having Codecov reporting on this PR.

gr2m commented 7 years ago

I’ve made you admin for this repo. I don’t think we need to configure a token for public repos when tests are running on travis

gr2m commented 7 years ago

Repository tokens are required for (a) all private repos, (b) public repos not using Travis-CI, CircleCI or AppVeyor.

https://github.com/codecov/example-node#nodejs--javascript-example

pvdlg commented 7 years ago

Ahhh...that's great ! I didn't know. That makes configuration even easier.

codecov-io commented 7 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@f411409). Click here to learn what that means. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             master    #74   +/-   ##
=======================================
  Coverage          ?   100%           
=======================================
  Files             ?      1           
  Lines             ?     25           
  Branches          ?      0           
=======================================
  Hits              ?     25           
  Misses            ?      0           
  Partials          ?      0

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f411409...f58b884. Read the comment docs.

pvdlg commented 7 years ago

I just want to make sure the PR status is reported properly before merging

pvdlg commented 7 years ago

We have to enable codecov Github app with this link: https://github.com/organizations/semantic-release/settings/installations/53605

For some reason I get a 404. Same issue with Greenkeeper by the way.

gr2m commented 7 years ago

Yeah there is something wonky, I’ve experienced it in other organisations where I was added recently. I’ve enabled codecov for the rpo