search

semantic-release / git

:twisted_rightwards_arrows: semantic-release plugin to commit release assets to the project's git repository
MIT License
303 stars 67 forks source link

ES Module? #490

Open csantos1113 opened 1 year ago

csantos1113 commented 1 year ago

I see semantic-release ESM was released Jan 6 https://github.com/semantic-release/semantic-release/releases/tag/v20.0.0 and multiple semantic-release plugins were updated to be ESM, including https://github.com/semantic-release/error/pull/249, but not @semantic-release/git, and I couldn't find any issues or PRs related to that.

So I have multiple questions on that regard:

Thank you

travi commented 1 year ago

as mentioned in our thread about the initial esm conversion, we are looking for community help for moving the remaining official plugins to esm, so we really appreciate your help getting that effort started for this plugin

  • How is this plugin not breaking?

the core of semantic-release is able to load both esm and common-js plugins. is there a specific reason you would expect loading this plugin would be broken?

csantos1113 commented 1 year ago

@travi thanks for replying.

is there a specific reason you would expect loading this plugin would be broken?

I landed here because I saw two versions of @semantic-release/error installed in my node_modules, and found out it was because @semantic-release/github and @semantic-release/npm install latest /error but @semantic-release/git and @semantic-release/changelog install old /error; so first thing that came to my mind was "How is this still working?!" - but thanks for the thread link and it makes sense!, I hadn't seen it before 🙏

please feel free to close this issue (or keep it open for traceability)