search

semantic-release / gitlab

:fox_face: semantic-release plugin to publish a GitLab release
MIT License
269 stars 78 forks source link

Replaced usage of assert keyword with "with" keyword to support node version 22.0.0 #705

Closed aldenbe closed 2 months ago

aldenbe commented 2 months ago

Fixes https://github.com/semantic-release/gitlab/issues/704

fgreinacher commented 2 months ago

Looks we need to bump our minimum supported Node version to 20.10.0 https://github.com/nodejs/node/pull/50682 because the with keyword support was only introduced in https://github.com/nodejs/node/pull/50140.

--

Or maybe even simpler we could just use require like the GitHub plugin: https://github.com/semantic-release/github/blob/master/lib/definitions/errors.js#L7

travi commented 2 months ago

I would be supportive of the breaking change within this plugin.

Looks like node v22 became "current" (will turn lts in six months) just a few days ago, which snuck up on at least me. Well likely see more folks running into this because of that update.

travi commented 2 months ago

closing in favor of https://github.com/semantic-release/gitlab/pull/708

thank you for bringing this to our attention!

aldenbe commented 2 months ago

I apologize, it was my belief that this feature was implemented in version 18.20.0 and therefore available in all subsequent versions, I did not fully understand that this 18 was an LTS version and that this feature would not necessarily be available in all versions of 20.x

fgreinacher commented 2 months ago

No worries, that Node.js change was introduced in a quite subtle way... Thanks a ton for reaching out so quickly!