search

semantic-release / gitlab

:fox_face: semantic-release plugin to publish a GitLab release
MIT License
278 stars 77 forks source link

Retrieve `CI_SERVER_URL` as `GITLAB_URL`? #720

Open huxuan opened 4 months ago

huxuan commented 4 months ago

According to the Predefined CI/CD variables reference, CI_SERVER_URL will just be what we want to GITLAB_URL, so when we are running on GitLab CI/CD, maybe it is better to retrieve the value by default?

fgreinacher commented 4 months ago

Thanks for reaching out! We do already have some logic to determine the default GitLab URL:

https://github.com/semantic-release/gitlab/blob/1aeabde29eef098ca9d096293ffa8d42d6590a05/lib/resolve-config.js#L31-L35

I agree that using CI_SERVER_URL would probably simplify this a bit as we would not need the project URL/path logic anymore.

Feel free to send a pull request :)