semantic-release / release-notes-generator

:clipboard: semantic-release plugin to generate changelog content with conventional-changelog
MIT License
298 stars 47 forks source link

chore: upgrade conventional commits #640

Closed icco closed 1 month ago

icco commented 1 month ago

This closes the following:

travi commented 1 month ago

Please make sure our tests are passing. npm test should be enough to verify this locally.

travi commented 1 month ago

Please make sure our tests are passing. npm test should be enough to verify this locally.

@icco the tests continue to fail after your follow up to pin the dev dependencies. are you interested in working through the breaking changes related to these updates in order to help us move this forward?

icco commented 1 month ago

Please make sure our tests are passing. npm test should be enough to verify this locally.

@icco the tests continue to fail after your follow up to pin the dev dependencies. are you interested in working through the breaking changes related to these updates in order to help us move this forward?

Yeah been trying to get the tests pass locally with no luck. I believe there's an underlying bug in the import plugin you use but can not figure it out.

travi commented 1 month ago

appreciate the update and the investigation. we are starting to investigate as well, but unsure how much time we can dedicate soon. please feel free to keep us up to date if you make progress, even if that means pushing wip changes that dont get to a point of getting tests to a passing state.

it could also be helpful to start with running the integration tests (npm run test:integration) first for a larger scope feedback loop before getting distracted by the unit tests (npm run test:unit) if the interface changes are unclear.

travi commented 1 month ago

appreciate the investment here, but closing in favor of https://github.com/semantic-release/release-notes-generator/pull/643. we could still use help updating the commit-analyzer plugin in similar ways in case you are still interested and the other PR helps with any complexities that you encountered with this effort