search

semantic-release / travis-deploy-once

🚫Test multiple node versions on Travis. Deploy once. If all of them pass.
MIT License
33 stars 7 forks source link

Support iojs and lts for node_js version #39

Closed pvdlg closed 6 years ago

pvdlg commented 6 years ago

Per Travis Node.js versions config, the value node, iojs and lts/* are supported for node_js.

This PR add supports for iojs and lts/* in addition of node.

gr2m commented 6 years ago

I’m not sure about this. iojs is legacy for a long time, I would rather not add it to our code base.

pvdlg commented 6 years ago

Yes but it's one of the valid configuration in Travis.

So if you configure your .travis.yml as follow:

node_js: iojs

Then we'll throw the error There is no job in this build defining a node version, please set BUILD_LEADER_ID to define the build leader yourself. which would be incorrect.

gr2m commented 6 years ago

I think the error is perfectly fine. Nobody should test in iojs any longer, I would no longer consider it a valid node version, just like Node < 4

pvdlg commented 6 years ago

Ok. I removed iojs.