cedoor commented 6 months ago

Description

The utils package will no longer provide errors and types utilities as those functions have been moved to ZK-Kit. The utils package now provides a list of supported networks and a function to decode messages instead.

The type of the identities' private key will always be a string type, either text or hexadecimal strings. This will allow devs to store private keys more easily and avoid confusion with types.

This PR still needs a fix in the @zk-kit/eddsa-poseidon library -> https://github.com/privacy-scaling-explorations/zk-kit/issues/187. Need to fix that before merging.

Related Issue(s)

Closes #700 Closes #642 Closes #641

Checklist

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have run yarn prettier and yarn lint without getting any errors
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules

openzeppelin-code[bot] commented 6 months ago

Update `utils` package and identity private key types.

Generated at commit: e510ab032fc4bacdf5b3f30e0a261acb2a213c47

🚨 Report Summary

Severity Level Results

Contracts Critical
High
Medium
Low
Note
Total 0
0
0
4
15
19

Dependencies Critical
High
Medium
Low
Note
Total 0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

	Severity Level	Results
Contracts	Critical High Medium Low Note Total	0 0 0 4 15 19
Dependencies	Critical High Medium Low Note Total	0 0 0 0 0 0

cedoor commented 6 months ago

Thanks!

There is an issue when running yarn test

Yes, waiting for a ZK-Kit fix.

aguzmant103 commented 5 months ago

@gitpoap-bot @cedoor

gitpoap-bot[bot] commented 5 months ago

Congrats, @cedoor ! You've earned a GitPOAP for your contribution!

GitPOAP: 2024 Semaphore Contributor:

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

aguzmant103 commented 5 months ago

@gitpoap-bot @vplasencia

gitpoap-bot[bot] commented 5 months ago

Congrats, @vplasencia ! You've earned a GitPOAP for your contribution!

GitPOAP: 2024 Semaphore Contributor:

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

aguzmant103 commented 5 months ago

@gitpoap-bot @0xjei

gitpoap-bot[bot] commented 5 months ago

Congrats, @0xjei ! You've earned a GitPOAP for your contribution!

GitPOAP: 2024 Semaphore Contributor:

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

semaphore-protocol / semaphore