semaphore-protocol / semaphore

A zero-knowledge protocol for anonymous interactions.
https://semaphore.pse.dev
MIT License
887 stars 194 forks source link

Use an incremental group id when creating a group in contracts #703

Closed vplasencia closed 6 months ago

vplasencia commented 6 months ago

Related Issue(s)

Closes #682

Checklist

openzeppelin-code[bot] commented 6 months ago

Use an incremental group id when creating a group in contracts

Generated at commit: b12dd0fd984fa3d5de9f2c2bd17f1e470cd6f4d1

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
0
0
0
4
16
20
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

vplasencia commented 6 months ago

Hey @cedoor I think that's a great idea, we could create a new issue. This will make it easier to use the function. There are a lot of cases where the admin is msg.sender.