Closed cedoor closed 7 months ago
Is your feature request related to a problem? Please describe.
After PR https://github.com/semaphore-protocol/semaphore/pull/703, there will be two functions to create a new group: createGroup(admin) and createGroup(admin, merkleTreeDuration).
createGroup(admin)
createGroup(admin, merkleTreeDuration)
admin is the address of the group group admin. That address usually is msg.sender, so a third function without any parameter could be added to the contracts: createGroup(), where indeed, the admin address = msg.sender.
admin
msg.sender
createGroup()
Additional context
Originated from message https://github.com/semaphore-protocol/semaphore/pull/703#pullrequestreview-1936961766.
Is your feature request related to a problem? Please describe.
After PR https://github.com/semaphore-protocol/semaphore/pull/703, there will be two functions to create a new group:
createGroup(admin)
andcreateGroup(admin, merkleTreeDuration)
.admin
is the address of the group group admin. That address usually ismsg.sender
, so a third function without any parameter could be added to the contracts:createGroup()
, where indeed, the admin address = msg.sender.Additional context
Originated from message https://github.com/semaphore-protocol/semaphore/pull/703#pullrequestreview-1936961766.