semaphore-protocol / semaphore

A zero-knowledge protocol for anonymous interactions.
https://semaphore.pse.dev
MIT License
908 stars 198 forks source link

Create a two-step mechanism to update group admins #718

Closed cedoor closed 7 months ago

cedoor commented 7 months ago

Description

The best practice to update a group admin is through a two-step update. The existing admin assigns the new potential admin, and the new admin accepts in a separate transaction. This prevents existing admins from making mistakes and assigning wrong addresses.

Open to naming suggestions.

Related Issue(s)

Closes #690

Checklist

vercel[bot] commented 7 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
semaphore-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 21, 2024 4:01pm
semaphore-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 21, 2024 4:01pm
openzeppelin-code[bot] commented 7 months ago

Create a two-step mechanism to update group admins

Generated at commit: 255bccf2ebc7a1ebfe06ebc7bb1bff2f8141fa83

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
0
0
0
4
16
20
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector