search

semaphore-protocol / semaphore

A zero-knowledge protocol for anonymous interactions.
https://semaphore.pse.dev
MIT License
883 stars 193 forks source link

ci: fix circom deps installation steps #751

Closed sripwoud closed 4 months ago

sripwoud commented 4 months ago

The circom deps in the pull requests workflow can't be install because there is an issue with their ubuntu repository (probably a temporary issue on the microsoft side related to their GPG keys).

As a temporary fix we can simply delete the microsoft source file in the workflow environment. Besides, as long as the integrity checks of the packages we get from the microsoft repo are broken, I think it is fine to not fetch packages from their repo at all. The drawback of not getting their softwares updates does not matter so much for us, as this is a ci environment we just use for running tests.

https://github.com/orgs/community/discussions/120966 https://stackoverflow.com/a/78377916

sripwoud commented 4 months ago

or we can just wait for microsoft to fix it probably not, this seems to be a recurring issue at microsoft. https://stackoverflow.com/a/78377916

So we could consider always skipping their repo in the ci?

gitpoap-bot[bot] commented 4 months ago

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2024 Semaphore Contributor:

GitPOAP: 2024 Semaphore Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.