Increase timeout for tests generating Semaphore proofs

vplasencia commented 3 months ago

Description

There is an error when running the test workflow:

Proof › # generateProof › Should generate a Semaphore proof

    thrown: "Exceeded timeout of 20000 ms for a test.

sripwoud commented 3 months ago

There are 2 different issues in that test(s):

Timeout for the proof generation: Increasing timeout can probably fix it. But I think the root cause is related to https://github.com/privacy-scaling-explorations/zk-kit/issues/280#issuecomment-2092459053
Structure of the test: Here We use a proof defined in the outer scope as parameter. It makes the tests depend on each others. As a result the test suite may produce unexpected results: a successful proof verification test requires the proof generation test having completed first, but jest executes everything in parallel...

cedoor commented 1 month ago

@vplasencia we shouldn't need this anymore. Can we close this issue?

vplasencia commented 1 month ago

I will close it. The PR was already merged some time ago.