fix(group): add check for zero values in group constructor - Githubissues

semaphore-protocol / semaphore

A zero-knowledge protocol for anonymous interactions.

https://semaphore.pse.dev

MIT License

883 stars 193 forks source link

fix(group): add check for zero values in group constructor #764

Closed cedoor closed 3 months ago

cedoor commented 3 months ago

Description

This PR adds a missing check in the Group class constructor to be sure there are no members with 0 as a value.

Checklist

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have run yarn format and yarn lint without getting any errors
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules