Fix inconsistent behavior when passing in user-provided private key - Githubissues

semaphore-protocol / semaphore

A zero-knowledge protocol for anonymous interactions.

https://semaphore.pse.dev

MIT License

876 stars 191 forks source link

Fix inconsistent behavior when passing in user-provided private key #801

Closed zkfriendly closed 1 month ago

zkfriendly commented 1 month ago

Related Issue(s)

Fixes #799

Checklist

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have run yarn format and yarn lint without getting any new errors
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

cedoor commented 1 month ago

Hey @zkfriendly, I already started working on this task. Here the branch: https://github.com/semaphore-protocol/semaphore/tree/fix/identity-generation.

There are some discussions going on about what's the best way to manage the input types. There will probably be some changes related to that in addition to the bugfix.