search

semaphore-protocol / semaphore

A zero-knowledge protocol for anonymous interactions.
https://semaphore.pse.dev
MIT License
876 stars 191 forks source link

Github workflows need to be revisited #808

Open cedoor opened 2 weeks ago

cedoor commented 2 weeks ago

Description

Semaphore's Github pull_requests workflow has recently been optimized to run some jobs only when related files are actually changed (https://github.com/semaphore-protocol/semaphore/pull/765). However, the file and folder paths to be considered for detecting changes do not take into account some configuration files, thus preventing some jobs from running even when they should.

Additionally, recently ZK-Kit has further optimized the workflows:

Semaphore workflows therefore need to be updated with the above points in mind. This issue is supposed to be used to discuss these points and converge on a final solution to be adopted.

cedoor commented 1 week ago

@sripwoud looks like there are other issues with the workflows after this PR: https://github.com/semaphore-protocol/semaphore/pull/810.

There are some warnings while building the libraries, and some untracked files are generated in the CLI templates.

sripwoud commented 1 week ago

which workflow/jobs exactly? There are quite a bunch ^^

cedoor commented 1 week ago

which workflow/jobs exactly? There are quite a bunch ^^

Sorry, it's not directly related to the workflow. You can try yourself by just running yarn build after cloning the repo. It looks like the --topological-dev option doesn't work well.