search

semaphore-protocol / semaphore

A zero-knowledge protocol for anonymous interactions.
https://semaphore.pse.dev
MIT License
908 stars 198 forks source link

Update UI code of `cli-template-monorepo-ethers` and `cli-template-monorepo-subgraph` #836

Closed vplasencia closed 1 week ago

vplasencia commented 3 months ago

Description

It would be nice to update the cli-template-monorepo-ethers and cli-template-monorepo-subgraph UI code with the same code as the boilerplate following the React good practices.

Boilerplate UI code: https://github.com/semaphore-protocol/boilerplate/tree/main/apps/web-app

yagopajarino commented 3 months ago

Hi @vplasencia, I may be able to contribute with this refactoring. Could you assign it to me?

vplasencia commented 3 months ago

Hey @yagopajarino ! Thank you. I just assigned you the issue. Let us know if you have any questions.

yagopajarino commented 3 months ago

Hi @vplasencia, I summited the PR but looks like it's failing everywhere. However I tested it locally and worked fine.

I realized the new UI uses chakra components, therefore some new packages need to be installed but github actions don't allow me to do so.

image

Let me know what you think and what changes should I do

vplasencia commented 3 months ago

Hey @yagopajarino thank you very much for the PR 🙏. I will take a look as soon as possible.