semaphore-protocol / semaphore

A zero-knowledge protocol for anonymous interactions.
https://semaphore.pse.dev
MIT License
929 stars 211 forks source link

Update cli monorepo ethers and subgraph web app UI #841

Closed yagopajarino closed 1 month ago

yagopajarino commented 4 months ago

Description

Update cli template ethers and subgraph web app UI using boilerplate code from https://github.com/semaphore-protocol/boilerplate/tree/main/apps/web-app

Related Issue(s)

Closes #836

Checklist

vplasencia commented 4 months ago

Hey @yagopajarino!

If you run yarn in the project root directory, do you see that the yarn.lock file was modified? If so, can you also push these changes?

yagopajarino commented 4 months ago

Pushed the new yarn.lock :)

cedoor commented 3 months ago

Hi @yagopajarino, could you solve the conflicts?

yagopajarino commented 3 months ago

Hi @cedoor! I just synced the fork and solved the conflicts, let me know if there are any additional changes needed

cedoor commented 3 months ago

@yagopajarino looks like there're still conflicts.

yagopajarino commented 3 months ago

Hi @cedoor! Fixed the conflicts

yagopajarino commented 3 months ago

Hello @vplasencia! I changed the .env and the .gitignore of both templates. In upcoming days I'll be replacing the chakra elements for plain html + css :)

vplasencia commented 3 months ago

Hey @yagopajarino! Thank you very much. No rush, take your time.

yagopajarino commented 2 months ago

Hi @vplasencia. I've been working on this :)

I made the changes on the ethers app, once it's ok I'll use that to update the hardhat one

cedoor commented 1 month ago

Hey @yagopajarino, any updates on this PR?

yagopajarino commented 1 month ago

Hi @cedoor! I'm waiting for review on the packages/cli-template-monorepo-ethers/apps/web-app

vplasencia commented 1 month ago

Hey @yagopajarino great work! Feel free to start updating the subgrah cli template.

yagopajarino commented 1 month ago

Hi @vplasencia made some changes, let me know what do you think :)

Btw thanks a lot for the reviews

yagopajarino commented 1 month ago

Thanks for the feedback! I made the changes

yagopajarino commented 1 month ago

Hi @vplasencia! Made the changes

vplasencia commented 1 month ago

Hey @yagopajarino thank you. Could you also remove the useSemaphore.ts file inside the hooks folder in both web apps?

yagopajarino commented 1 month ago

Done @vplasencia 🚀

gitpoap-bot[bot] commented 1 month ago

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2024 Semaphore Contributor:

GitPOAP: 2024 Semaphore Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.