semaphore-protocol / semaphore

A zero-knowledge protocol for anonymous interactions.
https://semaphore.pse.dev
MIT License
887 stars 194 forks source link

Semaphore Identity example code bug fix (Fix #848) #849

Closed csiejimmyliu closed 1 month ago

csiejimmyliu commented 1 month ago

Description

I deleted the undeclared input "signature" parameter in the signMessage function.

Issue

Closes #848

csiejimmyliu commented 1 month ago

Hey @vplasencia It says Merging is blocked(The base branch requires all commits to be signed.) I follow some instructions, but I can only sign the newest commit. Could you tell me how I can sign previous commits? (BTW this is my first pull request XD)

vplasencia commented 1 month ago

Hey @csiejimmyliu no worries. It's fine. Great work 🚀

gitpoap-bot[bot] commented 1 month ago

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2024 Semaphore Contributor:

GitPOAP: 2024 Semaphore Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.