search

semaphore-protocol / semaphore

A zero-knowledge protocol for anonymous interactions.
https://semaphore.pse.dev
MIT License
910 stars 201 forks source link

The subgraph `getGroups` function returns wrong members #858

Open vplasencia opened 1 month ago

vplasencia commented 1 month ago

Description

If there are two members in an on-chain Semaphore group and one of the members is removed, the getGroup function from the SemaphoreSubgraph class returns the old value of the member instead of the new value that should be 0.

It looks like the function does not take into account when a member is removed (probably also when the member is updated).

AjayAdsule commented 6 days ago

@vplasencia should i work on it, if yes please assign to me

vplasencia commented 5 days ago

Hey @AjayAdsule! Feel free to start working on it.