semaphore-protocol / website

Semaphore official website.
http://semaphore.pse.dev/
MIT License
9 stars 17 forks source link

docs: wrote Signal explanation in glossary #103

Closed Jo-Shino closed 1 year ago

Jo-Shino commented 1 year ago

Description

Related Issue

https://github.com/semaphore-protocol/website/issues/46

Jo-Shino commented 1 year ago

Hi,@cedoor @vplasencia could you check this pull request? Thank you.

vplasencia commented 1 year ago

Hey @Jo-Shino! Thank you so much for the definition. It looks great. I added a suggestion.

Jo-Shino commented 1 year ago

@vplasencia Thank you for pointing this out. I revised the text, so please check it again!

vplasencia commented 1 year ago

@Jo-Shino Thank you so much for updating the definition. After updating that word, everything is ready to merge. Would you like to update it? You can click the Commit suggestion button, so it is easier for you to create the commit.

Jo-Shino commented 1 year ago

@vplasencia I pushed commit suggestion button and updated the text. Thank you!

gitpoap-bot[bot] commented 1 year ago

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2023 Semaphore Contributor:

GitPOAP: 2023 Semaphore Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

vplasencia commented 1 year ago

Thank you so much @Jo-Shino for the contribution 🚀