semaphoreci / fastlane-plugin-semaphore

Fastlane plugin for running CI/CD on Semaphore
MIT License
2 stars 3 forks source link

Support for android... seems to only work on the mac images #5

Open JeremiahChurch opened 4 years ago

JeremiahChurch commented 4 years ago

The notes in the fastlane docs call this out to be run in a before_all block.

If I do that on an ubuntu android image - An exception is raised about keychain errors - it looks like there aren't guardrails if this is run in an android container image (like semaphoreci/android:29-node.)

example Fastfile:

before_all do
  setup_semaphore # exceptions happen on android image if left here
end

platform :ios do
  before_all do
    setup_sempahore # no problem here
  end
end

output:

512 | [23:04:24]: --- Step: setup_semaphore ---
514 | [23:04:24]: -----------------------------
515 | [23:04:24]: Creating temporary keychain: "semaphore_temporary_keychain".
515 | +---------------+------------------------+
517 | |              Lane Context              |
517 | +---------------+------------------------+
518 | | PLATFORM_NAME | android                |
520 | | LANE_NAME     | android capture_screen |
520 | +---------------+------------------------+
522 | [23:04:24]: Shell command exited with exit status 127 instead of 0.

Would it be possible to check the image this is being run on and safely skip trying to create the keychain if it will cause issues? Or if that's difficult - maybe just update docs for this plugin and the fastlane docs?

CommanderK5 commented 4 years ago

@JeremiahChurch thank you for reporting this issue. Fix was applied in pull request https://github.com/semaphoreci/fastlane-plugin-semaphore/pull/6.

iksi commented 3 years ago

@CommanderK5 Still running into this issue as v0.2.1 has not been published on RubyGems.org: https://rubygems.org/gems/fastlane-plugin-semaphore

shobhitpuri commented 2 years ago

Does fastlane come pre-installed in ubuntu images (or any plans)? If one wants to use fastlane for Android builds as well, does this work? @JeremiahChurch @CommanderK5

skipi commented 2 years ago

@shobhitpuri @iksi I've deployed versions 0.2.1 0.3.0 0.3.2 to RubyGems. Can you check if the issue persists?