search

semars / LaunchcodeMario

Java remake of CS50 mario
0 stars 0 forks source link

Pyramid Challenge #2

Open mpmenne opened 9 years ago

mpmenne commented 9 years ago

Hey Ethan,

Great job with the strategy design pattern. You really nailed, especially the details about using a try-with-resources.

Perhaps you're already working on this, but I want to challenge you to refactor you Mario class. See if you can get it even cleaner by extracting out the logic required to build the pyramid. Once you extract the Pyramid object I think the Factory pattern will flow naturally.

Cheers, Mike

semars commented 9 years ago

Hey Mike,

I appreciate the feedback. I'm still getting a handle on the Factory pattern and reading through Head First Design Patterns, but I think I got it implemented correctly in the pset3 branch.

Thanks for your help, Ethan

On Thu, Apr 30, 2015 at 1:02 AM, Mike Menne notifications@github.com wrote:

Hey Ethan,

Great job with the strategy design pattern. You really nailed, especially the details about using a try-with-resources.

Perhaps you're already working on this, but I want to challenge you to refactor you Mario class. See if you can get it even cleaner by extracting out the logic required to build the pyramid. Once you extract the Pyramid object I think the Factory pattern will flow naturally.

Cheers, Mike

— Reply to this email directly or view it on GitHub https://github.com/semars/LaunchcodeMario/issues/2.