search

sematext / logagent-js

Extensible log shipper with input/output plugins, buffering, parsing, data masking, and small memory/CPU footprint
https://sematext.com/logagent
Apache License 2.0
389 stars 79 forks source link

Cannot read property 'slice' of undefined #206

Open madsbredholt opened 4 years ago

madsbredholt commented 4 years ago

We get the following in our logs after having upgraded from 2.0.184 to 3.0.21.

2020-03-02T11:05:13.016Z v3.0.21 pid[6] Container 4c41c2667758bd56da960ff10957c6c4575e24591f2cb1edcf9b5aafb7215ce6 /tmp-xb-backup setting LOGSENE_ENABLED=true Please contact support@sematext.com to report the error: UncaughtException:TypeError: Cannot read property 'slice' of undefined TypeError: Cannot read property 'slice' of undefined at BufferList.shallowSlice (/usr/local/lib/node_modules/@sematext/logagent/node_modules/bl/bl.js:210:29) at DestroyableTransform. (/usr/local/lib/node_modules/@sematext/logagent/node_modules/docker-loghose/lib/parser.js:77:37) at Array.forEach () at DestroyableTransform.publish (/usr/local/lib/node_modules/@sematext/logagent/node_modules/docker-loghose/lib/parser.js:75:13) at DestroyableTransform.parse [as _transform] (/usr/local/lib/node_modules/@sematext/logagent/node_modules/docker-loghose/lib/parser.js:67:10) at DestroyableTransform.Transform._read (/usr/local/lib/node_modules/@sematext/logagent/node_modules/readable-stream/lib/_stream_transform.js:184:10) at DestroyableTransform.Transform._write (/usr/local/lib/node_modules/@sematext/logagent/node_modules/readable-stream/lib/_stream_transform.js:172:83) at doWrite (/usr/local/lib/node_modules/@sematext/logagent/node_modules/readable-stream/lib/_stream_writable.js:428:64) at writeOrBuffer (/usr/local/lib/node_modules/@sematext/logagent/node_modules/readable-stream/lib/_stream_writable.js:417:5) at DestroyableTransform.Writable.write (/usr/local/lib/node_modules/@sematext/logagent/node_modules/readable-stream/lib/_stream_writable.js:334:11)

adnanrahic commented 4 years ago

Hey @madsbredholt! Thanks for letting us know about this. I'm debugging this issue right away. Can you let me know how to exactly replicate this bug? What did you do and what is your configuration when this started happening? Thanks! :smile:

madsbredholt commented 4 years ago

Hi,

I am not sure how to replicate it.

I have not been able to figure out how to reproduce.

I have attached our docker stack file and logagent config files.

Regards Mads

Fra: Adnan Rahić notifications@github.com Sendt: tirsdag 3. mars 2020 10:49 Til: sematext/logagent-js logagent-js@noreply.github.com Kopi: Mads bredholt mads.bredholt@staminagroup.no; Mention mention@noreply.github.com Emne: Re: [sematext/logagent-js] Cannot read property 'slice' of undefined (#206)

Hey @madsbredholthttps://github.com/madsbredholt! Thanks for letting us know about this. I'm debugging this issue right away. Can you let me know how to exactly replicate this bug? What did you do and what is your configuration when this started happening? Thanks! 😄

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/sematext/logagent-js/issues/206?email_source=notifications&email_token=AB47WFET2VLHRVTD3SBFUQDRFTHCLA5CNFSM4K7SRDQ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENSZTYY#issuecomment-593861091, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AB47WFD7DQQDRRCUUWQTZK3RFTHCLANCNFSM4K7SRDQQ.

adnanrahic commented 4 years ago

Okay. I've tested the latest release with Docker Compose and running it with Docker from the command line. I'll take a look at your specific Docker Stack configuration, and get back to you.

adnanrahic commented 4 years ago

Hey @madsbredholt. I've tested every single case with your specific configuration and did not manage to reproduce the issue.

However, I did manage to find the reason why your configuration was not shipping parsed files from the host. PR #207 fixes it. I'll let you know once the fix is released.

megastef commented 4 years ago

@adnanrahic the original error is probably a problem reading the log data from docker socket. ‘docker-loghose/lib/parser.js:77:37’ - Did it happen while ‘dockerd’ service made a restart? Try to restart dockerd to reproduce it.

madsbredholt commented 4 years ago

Ok,

Thanks

Regards Mads

Fra: Adnan Rahić notifications@github.com Sendt: tirsdag 3. mars 2020 17:47 Til: sematext/logagent-js logagent-js@noreply.github.com Kopi: Mads bredholt mads.bredholt@staminagroup.no; Mention mention@noreply.github.com Emne: Re: [sematext/logagent-js] Cannot read property 'slice' of undefined (#206)

Hey @madsbredholthttps://github.com/madsbredholt. I've tested every single case with your specific configuration and did not manage to reproduce the issue.

However, I did manage to find the reason why your configuration was not shipping parsed files from the host. PR #207https://github.com/sematext/logagent-js/pull/207 fixes it. I'll let you know once the fix is released.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/sematext/logagent-js/issues/206?email_source=notifications&email_token=AB47WFDLN3VW5KIDZFDHO7LRFUYA7A5CNFSM4K7SRDQ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENUHYPQ#issuecomment-594050110, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AB47WFC6DMTRHH62HBZLLB3RFUYA7ANCNFSM4K7SRDQQ.

madsbredholt commented 4 years ago

We will try and get back to you.

Regards Mads

Fra: Megastef notifications@github.com Sendt: tirsdag 3. mars 2020 23:22 Til: sematext/logagent-js logagent-js@noreply.github.com Kopi: Mads bredholt mads.bredholt@staminagroup.no; Mention mention@noreply.github.com Emne: Re: [sematext/logagent-js] Cannot read property 'slice' of undefined (#206)

@adnanrahichttps://github.com/adnanrahic the original error is probably a problem reading the log data from docker socket. ‘docker-loghose/lib/parser.js:77:37’ - Did it happen while ‘docherd’ service made a restart? Try to restart dockerd to reproduce it.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/sematext/logagent-js/issues/206?email_source=notifications&email_token=AB47WFE44FD6VUCBS6KMUZ3RFV7KZA5CNFSM4K7SRDQ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENVMXZA#issuecomment-594201572, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AB47WFHSITLDYAQMNYMRLNLRFV7KZANCNFSM4K7SRDQQ.

adnanrahic commented 4 years ago

Sure, I'll wait for that. In the meantime, I've pushed version 3.0.22 that fixes your other issue, mentioned through email. :smile:

otisg commented 4 years ago

@madsbredholt can we assume this is no longer an issue for you?

madsbredholt commented 4 years ago

We have not had the opportunity to look at it for a while.

We will let you know if it occurs again 🙂

Regards Mads

Fra: Otis Gospodnetić notifications@github.com Sendt: tirsdag 5. mai 2020 22:51 Til: sematext/logagent-js logagent-js@noreply.github.com Kopi: Mads bredholt mads.bredholt@staminagroup.no; Mention mention@noreply.github.com Emne: Re: [sematext/logagent-js] Cannot read property 'slice' of undefined (#206)

@madsbredholthttps://github.com/madsbredholt can we assume this is no longer an issue for you?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/sematext/logagent-js/issues/206#issuecomment-624299371, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AB47WFARNPRHJUBK2OAPUA3RQB36PANCNFSM4K7SRDQQ.