search

sematext / sematext-agent-integrations

Core & Community developed monitoring integrations for Sematext monitoring agent
https://sematext.com/integrations
Apache License 2.0
13 stars 4 forks source link

Add integration checks to help improve integrations #23

Closed otisg closed 5 years ago

otisg commented 5 years ago

We should add simple integration checks that help the integration author polish the integration. Things like:

• "don't use /seconds, use /s" • here is a list of all distinct units you used: requests/min, requests/minute.... ("oh, look, I used both /min and /minute, let me fix that"), millis, milliseconds ("oh, wait, I should unify these. No, actually I should use ms, let me change that") • here is a list of metrics with a missing label: .... • here is a list of metrics with a missing description: ....

This will save time during PR reviews, help with unification across all integrations, let the PR reviewer focus on bigger, non-cosmetic things, etc.

otisg commented 5 years ago

@bsmid looks like I should close this issue in favour of https://github.com/sematext/sematext-agent-java/issues/33 ?

bsmid commented 5 years ago

Hm, yeah, sorry about that.