search

sematext / winston-logsene

Winston Transport for Logsene
http://sematext.com/logsene
Apache License 2.0
13 stars 6 forks source link

Moving conditional into parentheses. #5

Closed louib closed 8 years ago

louib commented 8 years ago

According to MDN, the ternary conditional operator comes just after the logical OR operator. This would result in the source being set to null when the source from the options was defined.

@megastef can you review :eyeglasses: ?

megastef commented 8 years ago

Thanks! Merged and I added the test. I assume you like to set the source name in the constructor options.

louib commented 8 years ago

@megastef yes, I set the source (usually the name of the application) once when instantiating the logger. Thanks for reviewing!