search

sembcorpp / pe

0 stars 0 forks source link

Able to add an internship that I applied for later than todays date #2

Open sembcorpp opened 1 year ago

sembcorpp commented 1 year ago

Screenshot 2023-04-14 at 2.22.24 PM.png

I tried to add an internship for foodpands that I "applied for" on the 16th of April, but today is 14th of April, so it should not be added since it has not passed the date yet. I put low severity because it does not really affect normal operations, and the app can still run as per normal with this bug

The code I typed was add n/Food Panda r/Web Developer s/Applied d/2023-04-16

nus-se-bot commented 1 year ago

Team's Response

Hello! Thank you for your input.

As mentioned in our user guide (page 11), the only requirement for DATE is that it must be a valid date of the correct format. Hence, what you have observed is the expected behaviour of InternBuddy.

image.png

In our implementation, we focused on making sure that the date is a valid date and must be of the correct format so that we can parse the input in InternBuddy. These 2 checks are much more important as compared to checking of a future date, as they are fundamental in ensuring that a "logical" value appears in the date field. Also, there is the possible case where the user wants to log an entry into InternBuddy in advance, before he actually apply for the internship. Our current implementation allows for such a case to happen, providing greater flexibility.

However, we hear your voice. We agree that we could have done better, such as providing a warning message to the user if he enters a status Applied and a future date, such as a message that says The date is in the future. Are you sure you want to enter this entry?. Such a warning message can help prevent accidental typo errors by the user.

Therefore, we would classify this issue as such:

  1. response.NotInScope because this feature is not an essential feature but rather a bonus that can help the user better avoid typo mistakes.
  2. severity.Low because it does not affect the normal functioning of the product, where users can still use the core features of InternBuddy as specified in the user guide.

We appreciate your input, and hope the above helps you! Cheers!

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

For "Applied" internships, the application allows me to input dates in the future.

When adding an internship with status = Applied and inputting a future date, the application does not flag it as an error. However, this is an outcome that can only be achieved if the user accidentally keyed in the date wrongly, but the application does not recognise this error.

image.png

[original: nus-cs2103-AY2223S2/pe-interim#4213] [original labels: severity.Low type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Hello! Thank you for your input.

As mentioned in our user guide (page 11), the only requirement for DATE is that it must be a valid date of the correct format. Hence, what you have observed is the expected behaviour of InternBuddy.

image.png

In our implementation, we focused on making sure that the date is a valid date and must be of the correct format so that we can parse the input in InternBuddy. These 2 checks are much more important as compared to checking of a future date, as they are fundamental in ensuring that a "logical" value appears in the date field. Also, there is the possible case where the user wants to log an entry into InternBuddy in advance, before he actually apply for the internship. Our current implementation allows for such a case to happen, providing greater flexibility.

However, we hear your voice. We agree that we could have done better, such as providing a warning message to the user if he enters a status Applied and a future date, such as a message that says The date is in the future. Are you sure you want to enter this entry?. Such a warning message can help prevent accidental typo errors by the user.

Therefore, we would classify this issue as such:

  1. response.NotInScope because this feature is not an essential feature but rather a bonus that can help the user better avoid typo mistakes.
  2. severity.Low because it does not affect the normal functioning of the product, where users can still use the core features of InternBuddy as specified in the user guide.

We appreciate your input, and hope the above helps you! Cheers!

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

## :question: Issue response Team chose [`response.NotInScope`] - [x] I disagree **Reason for disagreement:** I still believe that this is a feature flaw with low severity. It is important for dates keyed into the app to be valid. If an internship is put into the app with an invalid date, the user could misunderstand that it was an outdated internship opportunity and will delete it, so he/she would not look out for the internship company's reply, potentially ruining their career prospects. Of course, this happens if the user is careless, but an app should have at least a warning to tell the user that the date input was invalid. This should not be a bonus but a bug since we cannot assume that the user will always be on the ball, and may cause the user inconveniences which are potentially serious.