sembcorpp / pe

0 stars 0 forks source link

Able to add an internship where the deadline to accept the offer is before today's date #6

Open sembcorpp opened 1 year ago

sembcorpp commented 1 year ago

Screenshot 2023-04-14 at 3.03.25 PM.png

I was able to add an internship where the deadline to accept the internship position is past the day, as I put in february 1st 2023 as the deadline to accept and the app assumes that this internship is accepted, but it should not be the case since I cant accept the position anymore and there is a possibility that I did not accept that position. I put low as it may cause abit of problems but it should have occurred to the user that it is common sense to add only valid internship positions that are still available to him/her.

nus-pe-script commented 1 year ago

Team's Response

Hello there! Thanks for writing in.

I was able to add an internship where the deadline to accept the internship position is past the day, as I put in february 1st 2023 as the deadline to accept

This was allowed because of potential use cases in which this feature would be valuable. We can provide you with a sample use case.

Sample Use Case

A user has an internship offer with deadline of offer acceptance as 10/4/2023. However, he forgot to accept it by the deadline, and he replied to the company on 11/4/2023. The company replies to him that they would consider giving him a chance, but he would need to wait for their reply. The user now wants to track this entry in InternBuddy in case he forgets about it again. Hence, when he enters this entry into InternBuddy on 11/4/2023, his entry in InternBuddy would have a status of Offered and deadline of offer acceptance as 10/4/2023. It would not be the status of Accepted because his internship is not confirmed yet.

Hence, by allowing a user to enter an entry with a past deadline, it allows for the situations where the user forgot to enter an entry but could always do so in the future. This is a feature and not a bug. In fact, our team believes that it adds value to the user because we cannot expect users to be on the ball when tracking internships with InternBuddy. Hope the above clarifies!

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: I feel that this should be be at least a severity low as I would still consider it a bug.

I still consider this a bug as there should at least be a warning for people who accidentally key in the wrong deadline of acceptance and did not simply forget about accepting.

As for the case of the user forgetting to accept the internship offer past the deadline, I would consider that as an extreme edge case, because if the user actually wanted the internship, he would have at least stored it in the app to keep a reminder of it somewhere, so there would be no need to suddenly key it in after the deadline.

In addition, adding the internship into the app with a deadline that is already past the current date would not serve much purpose to the user as it would not even show up when the user uses the upcoming feature, so if the user wanted to see what are the upcoming deadlines for the next week, it would not even show up since the date keyed in is not within the next week. The user would have to either use the find feature or scroll through the app to find it specifically. For the case that the team have given in response, perhaps the new deadline to accept could have been changed to one within the next week so that it still shows up in the upcoming events for the user to see it so he/she does not forget about it again.