seme0021 / python-zillow

Python library for the Zillow API
Apache License 2.0
129 stars 64 forks source link

use https secure connection for requests #21

Closed vintlucky777 closed 6 years ago

vintlucky777 commented 6 years ago

because it's totally ain't cool to send API keys over http

jonafato commented 6 years ago

Thanks, this is great. The Zillow API documentation seems to only mention the HTTP endpoint, but from a cursory glance, this looks like it should just work (i.e. that domain has a valid certificate and serves up content over HTTPS).

Have you made actual requests against the HTTPS endpoint successfully? If so, I'll merge this now.

vintlucky777 commented 6 years ago

yes, it supports HTTPS, even more to that, this example cURL request verbose log

curl "https://www.zillow.com/webservice/GetSearchResults.htm?address=438+Sausalito+Boulevard%2C+Sausalito&citystatezip=94965&zws-id=$ZILLOW_KEY" -v

shows that on HTTPS the API is able to speak in HTTP/2