search

seme0021 / python-zillow

Python library for the Zillow API
Apache License 2.0
129 stars 64 forks source link

retnzestimate? #28

Open nitrocode opened 6 years ago

nitrocode commented 6 years ago

Noticed this misspelling in a few places and it might be setting the wrong flag in GetSearchResults() and GetZEstimate() functions

https://github.com/seme0021/python-zillow/blob/master/zillow/api.py#L55

nitrocode commented 6 years ago

@bhoscheit I don't think spamming all the issues is the best way to get help

RyanConway91 commented 5 years ago

Any updates on this? I am trying to get rent estimates for properties which I know have them (can view them through the zillow app) but cannot seem to get this information from the API wrapper. Any idea how to fix this? I am assuming the "retnzestimate"typo is part of the issue, as with "retnzestimate" you would not be accessing the "rentzestimate" property of API. I fixed these typos in the code I downloaded but still not getting the results.

bhoscheit commented 5 years ago

Hey Ryan!

What project are you working on?

On Sun, Mar 31, 2019 at 12:37 PM RyanConway91 notifications@github.com wrote:

Any updates on this? I am trying to get rent estimates for properties which I know have them (can view them through the zillow app) but cannot seem to get this information from the API wrapper. Any idea how to fix this? I am assuming the "retnzestimate"typo is part of the issue, as with "retnzestimate" you would not be accessing the "rentzestimate" property of API. I fixed these typos in the code I downloaded but still not getting the results.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/seme0021/python-zillow/issues/28#issuecomment-478373352, or mute the thread https://github.com/notifications/unsubscribe-auth/AQ3_dqtoonz75jJySpE9aPGR1S7lhzfmks5vcQ5bgaJpZM4THmNH .

RyanConway91 commented 5 years ago

Hey Ben, got it working! Found the updated code and it is working now. What do you mean "project"?

Thanks

bhoscheit commented 5 years ago

Great! I'm glad. I'm just curious/interested in what you are using the code for.

On Sun, Mar 31, 2019 at 1:19 PM RyanConway91 notifications@github.com wrote:

Hey Ben, got it working! Found the updated code and it is working now. What do you mean "project"?

Thanks

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/seme0021/python-zillow/issues/28#issuecomment-478378096, or mute the thread https://github.com/notifications/unsubscribe-auth/AQ3_diSQK3VjPvVdk1M7W8iT8aVYYjHUks5vcRhqgaJpZM4THmNH .

RyanConway91 commented 5 years ago

Oh okay I thought maybe "project" that was github lingo for something. I am trying automate an realestate investment calculator for the Minneapolis area.

bhoscheit commented 5 years ago

Ah, very funny! I was doing the same for the Madison, WI area when I was using this code a few months ago. Now the automatic ranking system netted us our first investment property. Well, goodluck with either your future product or investing! I would be interested in knowing how it pans out: bhoscheit5@gmail.com

Thanks! Ben

On Sun, Mar 31, 2019 at 1:23 PM RyanConway91 notifications@github.com wrote:

Oh okay I thought maybe "project" that was github lingo for something. I am trying automate an realestate investment calculator for the Minneapolis area.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/seme0021/python-zillow/issues/28#issuecomment-478378644, or mute the thread https://github.com/notifications/unsubscribe-auth/AQ3_dm7EOAvKKmdPilQhCp3xoPhIzCmOks5vcRk4gaJpZM4THmNH .

RyanConway91 commented 5 years ago

Thanks!

RyanConway91 commented 5 years ago 
    api = zillow.ValuationApi()
    data = api.GetDeepSearchResults(key, address, postal_code,rentzestimate = True)
    data_dict = data.get_dict()
    bdrms = data_dict['extended_data']['bedrooms']
    bthrms = data_dict['extended_data']['bathrooms']
    sqft = data_dict['extended_data']['bathrooms']
    lot_sqft = data_dict['extended_data']['lot_size_sqft']
    tax_ass = float(data_dict['extended_data']['tax_assessment'])
    tax_rate = 1.81/100
    tax = tax_ass*tax_rate

    rent_zest = data_dict['rentzestimate']['amount']
    rent_zest_high = data_dict['rentzestimate']['valuation_range_high']
    rent_zest_low = data_dict['rentzestimate']['valuation_range_low']

I may have modified the package code I don’t remember. If this doesn’t work let me know

Ryan J. Conway Hydrogeologist Minneapolis, MN office: 952.832.2846 cell: 715.338.4386 RConway@barr.com www.barr.com

[cid:image001.png@01D52D7D.A47412D0]

If you no longer wish to receive marketing e-mails from Barr, respond to communications@barr.com and we will be happy to honor your request.

From: Mark Black notifications@github.com Sent: Thursday, June 27, 2019 3:58 PM To: seme0021/python-zillow python-zillow@noreply.github.com Cc: Ryan J. Conway RConway@barr.com; Mention mention@noreply.github.com Subject: Re: [seme0021/python-zillow] retnzestimate? (#28)

Hey @RyanConway91https://github.com/RyanConway91 If you don't mind me asking how did you get the retnzestimate/rentestimate to work? I have tried setting the parameter to True and I have the latest and only version. Thanks!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/seme0021/python-zillow/issues/28?email_source=notifications&email_token=AGAETOMRTKWY5Q767RLGCO3P4USUVA5CNFSM4EY6MND2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYYLKLA#issuecomment-506508588, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AGAETOPZ7CISWY6TK6GPQ5TP4USUVANCNFSM4EY6MNDQ.

pmdbt commented 4 years ago

@RyanConway91 Hey Ryan, thanks for putting this repo together. I followed your code here:

api = zillow.ValuationApi()
        data = api.GetDeepSearchResults(key, address, postal_code,rentzestimate = True)
        data_dict = data.get_dict()
        bdrms = data_dict['extended_data']['bedrooms']
        bthrms = data_dict['extended_data']['bathrooms']
        sqft = data_dict['extended_data']['bathrooms']
        lot_sqft = data_dict['extended_data']['lot_size_sqft']
        tax_ass = float(data_dict['extended_data']['tax_assessment'])
        tax_rate = 1.81/100
        tax = tax_ass*tax_rate

        rent_zest = data_dict['rentzestimate']['amount']
        rent_zest_high = data_dict['rentzestimate']['valuation_range_high']
        rent_zest_low = data_dict['rentzestimate']['valuation_range_low']

However, I was getting an error:

TypeError: GetDeepSearchResults( ) got an unexpected keyword argument 'rentzestimate'

So, I looked at your source code and it appears you've made a syntax/spelling error on this line:

def GetDeepSearchResults(self, zws_id, address, citystatezip, retnzestimate=False):

You spelled rentzestimate as retnzestimate. The method "GetSearchResult()" has the same typo as well. Thought you should know and make a quick update :). I'm using version 0.2.0 for reference.

@nitrocode pointed this out in his original comment as well, but it doesn't appear to be fixed everywhere.

jecronin commented 4 years ago

@RyanConway91 circling back on @nitrocode and @pmdbt's notes. How is the spelling issue affecting the ability to pull in rentzestimate from the API? For example, if you go to this URL the rentzestimate is displayed in the XML but it is not when you call the Valuation API in python. The rent zestimate with the price would be great to do ROI calcs at scale for a batch of properties, all within python Thank you for your help!

https://www.zillow.com/webservice/GetSearchResults.htm?zws-id=X1-ZWz1h9tnvngv7v_31kch&address=11820+Melones+Circle&citystatezip=Gold+River%2c+CA&rentzestimate=True

image

nitrocode commented 4 years ago

It might be time to fork this repo or use another zillow package or another realestate api package

pmdbt commented 4 years ago

Agreed, I'm actually using my own version where I just changed all of the spelling errors and it works fine. If others are interested in volunteering and maintaining a fork, I'm happy to do it and make a commit to fix the spelling issues.

Sent via Superhuman ( https://sprh.mn/?vip=jerrychu123@gmail.com )

On Fri, Jun 26, 2020 at 3:34 PM, nitro < notifications@github.com > wrote:

It might be time to fork this repo or use another zillow api

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub ( https://github.com/seme0021/python-zillow/issues/28#issuecomment-650433263 ) , or unsubscribe ( https://github.com/notifications/unsubscribe-auth/AHRNNWM6UT7RZZYJCOAMPJTRYUPAHANCNFSM4EY6MNDQ ).

RyanConway91 commented 4 years ago

Yes, you need to fix the typos for the rentzestimate to work

Ryan J. Conway Hydrogeologist Minneapolis, MN office: 952.832.2846 cell: 715.338.4386 RConway@barr.com www.barr.com

[cid:image001.png@01D64C6F.FB02BDB0]

If you no longer wish to receive marketing e-mails from Barr, respond to communications@barr.com and we will be happy to honor your request.

From: Jerry Chu notifications@github.com Sent: Friday, June 26, 2020 5:48 PM To: seme0021/python-zillow python-zillow@noreply.github.com Cc: Ryan J. Conway RConway@barr.com; Mention mention@noreply.github.com Subject: Re: [seme0021/python-zillow] retnzestimate? (#28)

CAUTION: This email originated from outside your organization. Exercise caution when opening attachments or clicking links, especially from unknown senders. Agreed, I'm actually using my own version where I just changed all of the spelling errors and it works fine. If others are interested in volunteering and maintaining a fork, I'm happy to do it and make a commit to fix the spelling issues.

Sent via Superhuman ( https://sprh.mn/?vip=jerrychu123@gmail.comhttps://linkprotect.cudasvc.com/url?a=https%3a%2f%2fsprh.mn%2f%3fvip%3djerrychu123%40gmail.com&c=E,1,-8zeOChl87l4n9qBuJsjIabVVtvjd6xanVKrw7Tt0uJb7y02N30xhw0iqqM7dfordfdXRdEGqXa518vgcPOz0QinjG3IcZesFP2IJRRa&typo=1 )

On Fri, Jun 26, 2020 at 3:34 PM, nitro < notifications@github.commailto:notifications@github.com > wrote:

It might be time to fork this repo or use another zillow api

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub ( https://github.com/seme0021/python-zillow/issues/28#issuecomment-650433263 ) , or unsubscribe ( https://github.com/notifications/unsubscribe-auth/AHRNNWM6UT7RZZYJCOAMPJTRYUPAHANCNFSM4EY6MNDQ ).

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/seme0021/python-zillow/issues/28#issuecomment-650436743, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AGAETOJAGK3AU6WNNJGBNQDRYUQQ7ANCNFSM4EY6MNDQ.

jecronin commented 4 years ago

@pmdbt that would be great thank you! Sidebar: I talked to Max awhile back and he took me through Lofty. Amazing product, awesome work

jecronin commented 4 years ago

@RyanConway91, I've submitted a pull request to update the retnzestimate typos to rentzestimate. Thank you for your help!

thaskef commented 3 years ago

It would be amazing if we can get the rent estimate fixed. As is, everything works in a Google Colab notebook except for that. I wish someone could help so I don't have to go back and redo it all on a local machine.