codepathreview
commented
8 years ago :+1: nice work. A few notes after checking out the code:
- Your attention to UI/UX was impressive.
- Great job with all the animations
- Good to see you were able to format the timestamp cleanly
- Good to see you refreshed the timeline after composing a new tweet
- Nice touch with the character count being displayed while the user composes a tweet
- Nice to see you used a SwipeRefreshLayout library for easy timeline refreshes
- Glad to see you made the compose activity into a dialog instead
- Good to see you added ActiveAndroid annotations to the models
- Good job adding detailed view with reply functionality
- Great job embedding media image in tweet object
- Good job getting retweet and favorite counts correctly displayed
- Good job moving compose to FloatingActionButton
- Consider adding progress bars to your app whenever a network request goes out
Here's a detailed Project 3 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you could improve your submission.
Let us know if you have any other thoughts or questions about this assignment. Hopefully by now you feel pretty comfortable with all the major pieces to basic Android apps (Views, Controllers, ActionBar, Navigation, Models, Authentication, API Communication, Persistence, et al) and see how they all fit together. We are close now to a turning point in the course where you should be hitting a "critical mass" towards your knowledge of Android.
semerda
My app is complete, please review. /cc @codepathreview @codepath