This required reverting changes for the following languages because the Semgrep integration wasn't in sync:
Go (@yosefAlsuhaibani , @brandonspark)
Julia (@brandonspark)
There was also a tricky bug occurring only in Semgrep which was due to tree-sitter-vue which was solved by patching tree-sitter-vue (it was declaring tree_sitter_html_* functions that were apparently picked by the linker instead of the real tree-sitter-html functions). Here's the modified version of tree-sitter-vue we're now using: https://github.com/ikatyang/tree-sitter-vue/pull/30. I added a safeguard so that future updates of the tree-sitter-vue submodule fail gracefully if some tree_sitter_html_* functions make a comeback.
On my machine, regenerating the Hack grammar takes 16.4 GB of RAM. C# is the second biggest memory consumer with 14.2 GB.
Checklist
[x] Any new parsing code was already published, integrated, and merged into Semgrep. DO NOT MERGE THIS PR BEFORE THE SEMGREP INTEGRATION WORK WAS COMPLETED.
[x] Change has no security implications (otherwise, ping the security team)
This required reverting changes for the following languages because the Semgrep integration wasn't in sync:
There was also a tricky bug occurring only in Semgrep which was due to tree-sitter-vue which was solved by patching tree-sitter-vue (it was declaring
tree_sitter_html_*
functions that were apparently picked by the linker instead of the real tree-sitter-html functions). Here's the modified version of tree-sitter-vue we're now using: https://github.com/ikatyang/tree-sitter-vue/pull/30. I added a safeguard so that future updates of the tree-sitter-vue submodule fail gracefully if sometree_sitter_html_*
functions make a comeback.The accompanying pull requests are:
On my machine, regenerating the Hack grammar takes 16.4 GB of RAM. C# is the second biggest memory consumer with 14.2 GB.
Checklist