Remove Unicode hack from Go/Java/JavaScript/Python parsers

semgrep / pfff

pfff is mainly an OCaml API to write static analysis, dynamic analysis, code visualizations, code navigations, or style-preserving source-to-source transformations such as refactorings on source code.

https://semgrep.dev

Other

186 stars 29 forks source link

Remove Unicode hack from Go/Java/JavaScript/Python parsers #502

Closed mjambon closed 2 years ago

mjambon commented 2 years ago

Security

[x] Change has no security implications (otherwise, ping the security team)

mjambon commented 2 years ago

I don't understand the CI error: https://github.com/returntocorp/pfff/runs/4798203649?check_suite_focus=true

Also, it takes 10 minutes to reach this point due to all the ocaml dependencies being built from scratch. We could use the pre-built image if using ocaml 4.12.0 is ok (see config at https://github.com/returntocorp/ocaml-layer/blob/master/configs/ubuntu.sh).