This pull request introduces a significant refactor of the Tabs component, transitioning from React-specific patterns and libraries to those compatible with Solid.js. The changes aim to simplify the component's structure and improve its compatibility with Solid.js projects.
Summary
Replaced React testing utilities with solid-testing-library for component tests in Tabs.spec.tsx.
Commented out userEvent.setup() calls in tests, marking them for future replacement to align with Solid.js event handling.
Removed React-specific references, such as createRef and forwardRef, from both the component and its tests.
Transitioned state management from React's useState to Solid.js's createSignal within Tabs.tsx.
Replaced React's conditional rendering and list rendering patterns with Solid.js's <Show> and <For> directives, respectively.
Adjusted tab item class application to use a ternary operation inline, streamlining the logic for applying active and disabled styles.
Updated type imports to reflect Solid.js types instead of React types, ensuring the component's props and event handlers are correctly typed for Solid.js.
General cleanup of unused imports and adjustments to accommodate Solid.js patterns, such as effect and signal usage.
These changes collectively overhaul the Tabs component to be more in line with Solid.js conventions, improving its maintainability and ease of use within Solid.js projects.
Fixes #25.
🎉 Latest improvements to Sweep:
New dashboard launched for real-time tracking of Sweep issues, covering all stages from search to coding.
Integration of OpenAI's latest Assistant API for more efficient and reliable code planning and editing, improving speed by 3x.
Description
This pull request introduces a significant refactor of the
Tabs
component, transitioning from React-specific patterns and libraries to those compatible with Solid.js. The changes aim to simplify the component's structure and improve its compatibility with Solid.js projects.Summary
solid-testing-library
for component tests inTabs.spec.tsx
.userEvent.setup()
calls in tests, marking them for future replacement to align with Solid.js event handling.createRef
andforwardRef
, from both the component and its tests.useState
to Solid.js'screateSignal
withinTabs.tsx
.<Show>
and<For>
directives, respectively.These changes collectively overhaul the
Tabs
component to be more in line with Solid.js conventions, improving its maintainability and ease of use within Solid.js projects.Fixes #25.
🎉 Latest improvements to Sweep:
💡 To get Sweep to edit this pull request, you can: