Feature Smart::Comments

semifor / Net-Twitter

A Perl interface to the Twitter APIs

83 stars 37 forks source link

Feature Smart::Comments #30

Closed cmlh closed 11 years ago

cmlh commented 11 years ago

I renamed $status to $statuses_ref to reflect Perl Best Practices

I have also incorporated the Smart::Comments CPAN Module which can be enabled by removing the "#" characters at the beginning of the line below:

# use Smart::Comments;

The Smart::Comments CPAN Module will print similar text (i.e. the example quoted below is specific to my twitter account) to STDERR:

### \$statuses_count is: 4023

### \$max_id is: '345706738261037056'

The next stage is to create a sub() to traverse the last 3200 tweets from timeline.

Please let me know if you prefer to receive pull requests from a topic branch instead of Master?

semifor commented 11 years ago

@cmlh I appreciate your work on this, but I'm going to decline this PR.

I disagree with the PBR advice re: _ref, except perhaps when the variable is a references to scalar. When it's a reference to a hash, array, or code, the name and context should be sufficent. I think the _ref suffix just makes the code less readable.
Smart comments can be very useful. They could, I think, add confusion for novice users. Since this is supposed to be a trivial example, I'd like to keep it as free of unnecessary constructs as possible.

I hope I don't discourage you from further contributions. Thank you!

cmlh commented 11 years ago

@semifor,

No not at all and I am in agreement with a majority of what you have stated.

Perhaps the solution would be to fork oauth_desktop.pl to create a more complex separate example within Net::Twitter? I'll create new pull requests as I refactor oauth_desktop.pl so you can monitor its development