semifor / net-twitter-lite

A lighter weight (non-Moose) Perl interface to the Twitter API
Other
26 stars 11 forks source link

API DELETE methods are not supported #4

Closed DexterTheDragon closed 13 years ago

DexterTheDragon commented 13 years ago

There are 3 api methods that use the DELETE http method: delete_list, delete_list_member, unsubscribe_list. These methods fail with the message "unexpected http_method: DELETE". It seems to be from this spot in the code: https://github.com/semifor/net-twitter-lite/blob/master/src/net-twitter-lite.tt2#L323-352 It appears to be handling GET and POST methods, but not DELETE.

Here are the twitter api pages for reference.

DexterTheDragon commented 13 years ago

P.S. After more inspection it looks like this was fixed in commit https://github.com/semifor/net-twitter-lite/commit/4069cf66e3abd41d572a2391985183902cd43cbe but only for _basic_authenticated_request and not for _oauth_authenticated_request

semifor commented 13 years ago

Thanks for reporting the bug!

I committed a fix and prepared a new distribution. The new distribution brings Net::Twitter::Lite feature current with Net::Twitter 3.16000. Would you mind testing the new release before I upload it to CPAN?

You can find the tarball at: http://www.questright.com/files/Net-Twitter-Lite-0.10004.tar.gz

DexterTheDragon commented 13 years ago

Tested it and looks like it works.

semifor commented 13 years ago

Thanks, I'll upload it to CPAN, now.