search

semigroups / Semigroups

The GAP package Semigroups
https://semigroups.github.io/Semigroups/
Other
23 stars 36 forks source link

build: try fix gap pkg distro #958

Closed james-d-mitchell closed 12 months ago

james-d-mitchell commented 12 months ago

Trying to address:

https://github.com/gap-system/PackageDistro/pull/833#issuecomment-1723887384

james-d-mitchell commented 12 months ago

@fingolfin this seems to have failed, what's the difference in the setup between the package distro and here that makes all of the tests pass here but not in the package distro?

fingolfin commented 12 months ago

I suggested a fix for this PR (annoyingly shell scripts and Makefiles use different syntax for interpolating variables sigh

To be honest, I do not yet understand why it works here and also on my own Ubuntu box -- I would expect it to fail in more circumstances... So I do not (yet) understand why it fails in the package distro CI and passes here. The package distro doesn't really do anything weird, either... Hum

james-d-mitchell commented 12 months ago

Thanks @fingolfin I've committed your suggestion, let's hope that this passes. If it does, should I just make another release, and then see if this fixes the failing tests for the package distro?

fingolfin commented 12 months ago

If it is not too much of an inconvenience for you, that would be great. With sone look it'll just pass and we can move on. If not, at least it shouldn't be worse than before, and I'll try to dig deeper...

james-d-mitchell commented 12 months ago

@fingolfin, no problem, I'll try to make a release later today!